search

ctrl-Felix / cosmospy-protobuf

Cosmos Protobuf library
16 stars 14 forks source link

generate stubs for grpclib #12

Closed xloem closed 11 months ago

xloem commented 1 year ago

grpclib is a pure-python grpc library at https://github.com/vmagamedov/grpclib

EDIT: grpclib's 0.4.5 release addresses the minor bug i mentioned here and i've force-pushed a requirements.txt that references it.

because grpcio generates stubs into [name]_pb2_grpc.py, and grpclib generates stubs into [name]_grpc.py, both stubs can coexist peacefully in the same package, although it would be clearer to rename the files based on the backend they assume is present.

xloem commented 1 year ago

I've added the styling changes recommended by the restyled tests. I'm unsure why they are so extensive. My changes can be seen alone at EDIT: https://github.com/ctrl-Felix/cosmospy-protobuf/pull/12/commits/a536a824920c9a5f4e2c0ca0bb065f0fa48ba692 . I also noticed requirements.txt is not used and instead updated the README. I'm using force pushes to keep the restyling changes, which I did not expect, separate.

ctrl-Felix commented 1 year ago

Hi, thank you for the PR and sorry for my late answer. I am a bit busy lately but I will give it in the upcoming days!

xloem commented 1 year ago

I've updating the restyling changes so the tests pass again. Still not sure why the tests want them in areas I haven't touched. Haven't looked at it.