search

ctrl-Felix / cosmospy-protobuf

Cosmos Protobuf library
16 stars 14 forks source link

Simplify aggregation #16

Closed xloem closed 11 months ago

xloem commented 11 months ago

This is a change I'm using locally to ease integratation of more chains.

The protobuf path algorithm is simplified to take only the last component.

Right now I have only added a port and upgrade for cosmos, mostly because I haven't finished porting osmosis yet, it has breaking changes between versions and the node I use recently upgraded to v16, whereas the repository has v14 ... locally i am using different packages for these (osmosis14_protobuf, osmosis15_protobuf, osmosis16_protobuf).

I remove the official google protobufs because google's packages build them with a different compiler version, which clashes.

ctrl-Felix commented 11 months ago

Thank you for the commit!

ctrl-Felix commented 11 months ago

I've just added tests to the package and while doing that I was wondering what specifically you mean with "I remove the official google protobufs". Because I noticed they are not completely removed. For instance the descriptor.proto is still imported from the google package.

So I was wondering what issues you specifically had?

xloem commented 11 months ago

Some of the commit content here is not quite what I thought I was contributing, and I’m afraid I’m not presently working the code, as I encountered significant issues earlier in my project.

I think when you remove or include google you need to inform protoletariat whether to import it relative or absolute as well, which I hadn’t realized when contibuting this.