search

ctrlaltcoop / certbot-dns-hetzner

Certbot plugin enabling dns-01 challenge on the Hetzner DNS API
Other
155 stars 24 forks source link

TTL is hardcoded to 60 seconds #1

Closed m6w6 closed 4 years ago

m6w6 commented 4 years ago

The TTL for created records is hardcoded to 60 seconds in dns_hetzner.py, shouldn't it use the dns-hetzner-propagation-seconds option?

l0rn commented 4 years ago

Actually no - the propagation seconds is not the TTL, it is the time that is waited until certbot will check whether the challenge has propagated throughout the DNS hierarchy. As different providers tend to propagate in a different amount of time it's configurable. The TTL should be set to a sane default which i chose to be 60 seconds. I can't see why this needs to be configurable.