search

ctrlaltcoop / certbot-dns-hetzner

Certbot plugin enabling dns-01 challenge on the Hetzner DNS API
Other
156 stars 27 forks source link

Remove zope dependency #18

Closed xenrox closed 1 year ago

xenrox commented 1 year ago

Release 2.0.0 of certbot removed the zope based interfaces.

l0rn commented 1 year ago

Does it work by just removing them? Don't we need to replace them with abc based interfaces?

xenrox commented 1 year ago

Yes just removing them is enough. I have tested this code on my setup and it worked flawlessly.

Further I just did a quick GitHub search and it seems like other certbot projects are using the same way forward: https://github.com/Infomaniak/certbot-dns-infomaniak/commit/36fa777c02def1c88b2e77ba8eadc0f8c38889ab https://github.com/hsmade/certbot-dns-transip/commit/bdec8dfbabb35be0033965246e80fde5d78d8abe

l0rn commented 1 year ago

ok, i'll gonna test it out on my own and release a new version