ctrlaltcoop / certbot-dns-hetzner

Certbot plugin enabling dns-01 challenge on the Hetzner DNS API
Other
155 stars 24 forks source link

Release 2.0 #20

Closed l0rn closed 1 year ago

l0rn commented 1 year ago

This commit introduces potentially breaking changes as it adjust this plugin to be compatible with certbot >=2.0 and implements best practices from certbot2.

codecov[bot] commented 1 year ago

Codecov Report

Merging #20 (2300d53) into main (18a30b0) will decrease coverage by 1.88%. The diff coverage is 85.71%.

:exclamation: Current head 2300d53 differs from pull request most recent head a9beb49. Consider uploading reports for the commit a9beb49 to get more accurate results

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   91.47%   89.58%   -1.89%     
==========================================
  Files           3        2       -1     
  Lines         129       48      -81     
==========================================
- Hits          118       43      -75     
+ Misses         11        5       -6     
Flag Coverage Δ
unittests 89.58% <85.71%> (-1.89%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
certbot_dns_hetzner/dns_hetzner.py 86.48% <82.60%> (-3.26%) :arrow_down:
certbot_dns_hetzner/fakes.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.