Closed richardhuxton closed 2 months ago
@richardhuxton this should be fixed with v2.0.1 Feedback would be great :)
I've just tried it out now and forced a refresh of a certificate with 2.0.1 and I can confirm that 2.0.1 works with my .com.de
domain.
Thanks very much!
This one took me a little time to figure out what was going on, but basically when identifying the zone for dns updates on hetzner you use
tldextract
which with default settings doesn't give the right response. So, belowcom.de
is a top-level zone the same asco.uk
and needs theinclude_psl_private_domains
flag set.As far as I can see it is safe to supply the flag in all cases (https://github.com/john-kurkowski/tldextract?tab=readme-ov-file#public-vs-private-domains) but I'm no dns expert.
The other option would seem to be use of the "lexicon" alternative. It seems like that library is already in use and can use dns-python (which might work better)?
https://dns-lexicon.readthedocs.io/en/latest/user_guide.html#resolution-of-the-zone-name
PS - thanks for the plugin