search

ctrlaltcoop / certbot-dns-hetzner

Certbot plugin enabling dns-01 challenge on the Hetzner DNS API
Other
155 stars 24 forks source link

Use dns-lexicon's Client instead of deprecated providers #27

Closed fupduck closed 2 months ago

fupduck commented 2 months ago

lexicon.providers.* is deprecated and it is suggested to use lexicon.client.Client instead.
Therefore I tried to implement the new approach.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.36%. Comparing base (8dc9d21) to head (0cef292).

Files Patch % Lines
certbot_dns_hetzner/dns_hetzner.py 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ========================================== - Coverage 89.58% 89.36% -0.23% ========================================== Files 2 2 Lines 48 47 -1 ========================================== - Hits 43 42 -1 Misses 5 5 ``` | [Flag](https://app.codecov.io/gh/ctrlaltcoop/certbot-dns-hetzner/pull/27/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ctrlaltcoop) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ctrlaltcoop/certbot-dns-hetzner/pull/27/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ctrlaltcoop) | `89.36% <80.00%> (-0.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ctrlaltcoop#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.