search

ctrlaltcoop / certbot-dns-hetzner

Certbot plugin enabling dns-01 challenge on the Hetzner DNS API
Other
155 stars 24 forks source link

Include private domains #28

Closed fupduck closed 2 months ago

fupduck commented 2 months ago

In issue 24 problems regarding private tlds were mentioned.

To fix this I now include them. I did not see a reason to not change this.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (d01d568) to head (40fd0d7).

Files Patch % Lines
certbot_dns_hetzner/dns_hetzner.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================== - Coverage 89.36% 87.50% -1.87% ========================================== Files 2 2 Lines 47 48 +1 ========================================== Hits 42 42 - Misses 5 6 +1 ``` | [Flag](https://app.codecov.io/gh/ctrlaltcoop/certbot-dns-hetzner/pull/28/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ctrlaltcoop) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ctrlaltcoop/certbot-dns-hetzner/pull/28/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ctrlaltcoop) | `87.50% <0.00%> (-1.87%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ctrlaltcoop#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.