search

ctrlaltcoop / certbot-dns-hetzner

Certbot plugin enabling dns-01 challenge on the Hetzner DNS API
Other
155 stars 24 forks source link

Plugin legacy name certbot-dns-hetzner:dns-hetzner may be removed in a future version #8

Closed robertoschwald closed 3 years ago

robertoschwald commented 3 years ago

Since today, I receive this warning on all hosts using this plugin:

Plugin legacy name certbot-dns-hetzner:dns-hetzner may be removed in a future version. Please use dns-hetzner instead.

# certbot renew --force-renewal
Saving debug log to /var/log/letsencrypt/letsencrypt.log

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Processing /etc/letsencrypt/renewal/xxx.yyy.zzz.conf
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Plugin legacy name certbot-dns-hetzner:dns-hetzner may be removed in a future version. Please use dns-hetzner instead.
Plugins selected: Authenticator certbot-dns-hetzner:dns-hetzner, Installer apache
Renewing an existing certificate
Running deploy-hook command: systemctl reload httpd

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
new certificate deployed with reload of apache server; fullchain is
...

So what should I do to migrate? Please add the info to the README. Thanks.

certbot 1.7.0 certbot-dns-hetzner 1.0.4

l0rn commented 3 years ago

To be completely honest - I don't know yet... I get this warning too and will figure it out eventually

robertoschwald commented 3 years ago

You can omit the prefix completely to get rid of the warning. Note: You also need to remove the prefix from the ini file. Maybe worth to update the README?

certbot certonly \
--authenticator dns-hetzner \
--dns-hetzner-credentials /etc/sysconfig/certbot-hetzner.ini \
--dns-hetzner-propagation-seconds 120 \
--email hostmaster@example.com --agree-tos -d myhost.example.com

Ini file:

dns_hetzner_api_token = ....
l0rn commented 3 years ago

cool thx for the reply, will amend the readme

l0rn commented 3 years ago

fixed with #10

tim-seoss commented 3 years ago

From what I can remember, this will break on older versions of certbot (which I think requires the previous syntax)? I could be wrong, but this might be worth checking? If that is the case, then it might be useful to note this (and document the "old" syntax).