_JpnPostalMark is missing cmap entry for U+3012

ctrlcctrlv / FRBAmericanCursive

An educational cursive font family. Supports color (“emoji”) font technology; consists of 50+ fonts.

GNU General Public License v3.0

50 stars 1 forks source link

_JpnPostalMark is missing cmap entry for U+3012 #2

Open dscorbett opened 3 years ago

dscorbett commented 3 years ago

Version 1.1 includes a glyph called _JpnPostalMark whose name implies it represents U+3012 POSTAL MARK. However, it is mapped to the nearly homoglyphic but otherwise unrelated U+20B8 TENGE SIGN. Was that intentional?

ctrlcctrlv commented 3 years ago

It was intentional, however, it seems that I forgot the cmap entry that would make _JpnPostalMark resolve to both U+20B8 and U+3012…

dscorbett commented 3 years ago

I just downloaded version 1.2, but it doesn’t support U+3012.

ctrlcctrlv commented 3 years ago

Really? I believe you, but you can see that I added it:

Maybe a fontmake issue, or perhaps MFEKstroke doesn't understand multiple <unicode> values (MFEK/glyphparser.rlib issue).

https://github.com/ctrlcctrlv/FRBAmericanCursive/blob/df5b0678c4c821584319e06ce7a9cf4ae9166742/FRBAmericanCursive-SOURCE.ufo/glyphs/_J_pnP_ostalM_ark.glif#L5

Please double check.

dscorbett commented 3 years ago

$ wget https://github.com/ctrlcctrlv/FRBAmericanCursive/releases/download/v1.2/FRBAmericanCursive.zip
$ unzip FRBAmericanCursive.zip
$ hb-shape dist/FRBAmericanCursive-400-Regular.otf -u 3012
[.notdef=0+500]

ctrlcctrlv commented 3 years ago

Thank you, reopened. I think the problem is in MFEK/glifparser.rlib. I'm not sure when that'll be fixed, but I'll make sure to triple-check this before 1.3. Thanks for your diligence.