search

ctrlcctrlv / infinity

A vichan fork permitting users to create their own boards
Other
318 stars 149 forks source link

https fallback to http no longer works with images #258

Open Elevon opened 9 years ago

Elevon commented 9 years ago

When 8chan is loaded via plain http (such as by IE or .net applications under Windows XP since it doesn't support old cipher suites) it now tries to link images and display thumbnails via https regardless, so for anyone forced to access the site without https images are broken.

Some old threads like this one still exhibit the old behavior where pages accessed with http link images via http, it looks like threads with media.8chan.co links are the ones affected. media.8chan images/thumbnails still load fine with http if the url is manually modified, it's just that they're always linked with https even if the page is being accessed via http.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

czaks commented 9 years ago

try linking to //media.8chan.co instead of https://media...

Elevon commented 9 years ago

Looking at the page source this seems to be what the old version effectively did because it used relative urls. Old: <div class="file"><p class="fileinfo">File: <a href="/meta/src/1414526522506.jpg">1414526522506.jpg</a>

New: <div class="file"><p class="fileinfo">File: <a href="https://media.8chan.co/gg/src/1415839366657.gif">1415839366657.gif</a>

It seems to be how halfchan does it for whatever that's worth:

<div class="fileText" id="fT45153908">File: <a href="//i.4cdn.org/g/1415931106738.jpg"

I don't know if using protocol-relative urls introduces any potential problems though.

desudesutalk commented 9 years ago

It will be VERY nice to use protocol-less links to images as 8chan is now blocked in Russia. Blocking is mostly done by URL, so with http only explicit content is blocked. But with https whole site is blocked because it is impossible to filter such traffic by URL.