ctrlcctrlv / infinity

A vichan fork permitting users to create their own boards
Other
318 stars 149 forks source link

Animate post form options toggle #425

Closed marktaiwan closed 9 years ago

marktaiwan commented 9 years ago

Uses jQuery's slideUp and slideDown effect for toggling the options table

Added linebreaks before option hints to minimize post form width change on toggle.

ctrlcctrlv commented 9 years ago

i hate to be the destroyer of fun but i really hate animated UI. nothing being animated is a conscious design choice

lots of websites do it today and it's just slow on older computers while being pointless rice

sorry ;_;

marktaiwan commented 9 years ago

@ctrlcctrlv That is fine. The new file selector I'm currently working on has CSS3 transition on mouse overs, shall I remove them as well? https://8ch.net/operate/res/2166.html#8231 Additionally, I wanted to ask if you think it should be a toggleable user options, or be made into the default feature, and if so should I provide a fallback for incompatible browsers (IE9 and older)?

ctrlcctrlv commented 9 years ago

nah, that's not obnoxious. transitions can stay

very nice script by the way

also, yes please let's make this optional, enabled by default. it should be easy because it doesn't require markup changes

also, one minor thing, i would probably replace "shit" with "stuff", it's true that we are a chan but probably not good to have curses in the post form lol

marktaiwan commented 9 years ago

@ctrlcctrlv haha, don't sweat it, I only leave crude user facing contents on prototypes, I have every intention of removing that from the code that will get merged.

Also, while it's true it doesn't require template changes, I'd prefer to edit it so that the the old selector is hidden and the new one displayed by default, so as to avoid page redraw when onready or $(document).ready fires.