search

ctrlplusb / react-async-component

Resolve components asynchronously, with support for code splitting and advanced server side rendering use cases.
MIT License
1.45k stars 62 forks source link

Use external PropTypes for better support. #28

Closed birkir closed 7 years ago

birkir commented 7 years ago

Long term support, react 15.5.

I am not familiar with peerDependencies, is this correct Sean?

codecov[bot] commented 7 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files           3        3           
  Lines          82       82           
=======================================
  Hits           80       80           
  Misses          2        2
Impacted Files Coverage Δ
src/asyncComponent.js 97.01% <ø> (ø) :arrow_up:
src/AsyncComponentProvider.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0899886...8c68c2e. Read the comment docs.

ctrlplusb commented 7 years ago

Awesome thanks for this! Will have a look.

DPr00f commented 7 years ago

Upvote :D

ctrlplusb commented 7 years ago

All good in the hood. ❤️