search

ctrlplusb / react-async-component

Resolve components asynchronously, with support for code splitting and advanced server side rendering use cases.
MIT License
1.45k stars 62 forks source link

updating proptypes #53

Closed cpeddecord closed 3 years ago

cpeddecord commented 6 years ago

haven't made the jump to latest version of this package but we're looking to move to React 16 so...

n1ru4l commented 6 years ago

@cpeddecord Could you fix the issues? Looking forward getting this merged. I also want to upgrade to React 16!

ctrlplusb commented 6 years ago

Closing this as we are using prop-types package now. Thanks!

cpeddecord commented 6 years ago

@ctrlplusb this was on your 0.x.x branch, not master.

ctrlplusb commented 6 years ago

Ah oki I missed that. I will look into it again. Apologies.

cpeddecord commented 6 years ago

@ctrlplusb I'm not sure why there are merge conflicts on this PR... any help would be appreciated.