search

ctrlplusb / react-async-component

Resolve components asynchronously, with support for code splitting and advanced server side rendering use cases.
MIT License
1.45k stars 62 forks source link

fixes #44 #74

Open hoschi opened 6 years ago

hoschi commented 6 years ago

My try for #44, let me now if something should be different.

codecov[bot] commented 6 years ago

Codecov Report

Merging #74 into master will decrease coverage by 4.79%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #74     +/-   ##
=========================================
- Coverage   94.38%   89.58%   -4.8%     
=========================================
  Files           3        3             
  Lines          89       96      +7     
  Branches       25       27      +2     
=========================================
+ Hits           84       86      +2     
- Misses          5        8      +3     
- Partials        0        2      +2
Impacted Files Coverage Δ
src/asyncComponent.js 89.74% <100%> (-3.22%) :arrow_down:
src/createAsyncContext.js 75% <0%> (-25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94fc382...9e4adee. Read the comment docs.