search

ctrlplusb / react-async-component

Resolve components asynchronously, with support for code splitting and advanced server side rendering use cases.
MIT License
1.45k stars 62 forks source link

Error async-component, state not reloaded after error #98

Open peppescg opened 5 years ago

peppescg commented 5 years ago

Hi @ctrlplusb I have a problem when a component has an error on resolving. I am using async-component for decorating every routes. If there are some connection troubles and I go to a specific not loaded route, the asyncComponent will render ErrorComponent or null. Great.

if (error) { return ErrorComponent ? React__default.createElement(ErrorComponent, _extends({}, this.props, { error: error })) : null; }

But after that, if change route, go to home page ( the connection is coming back ) and after that I try to go back to the route before ( the route that I had connection trouble ), the state of asyncComponent should not be dirty, the component will not be rendered, because I will have the same error, despite the connection is come back.

I suggest to add a prop for setting the state to default, in this way, the developer can decide to render again a component if it has an error. What do you think?