search

ctrlplusb / react-component-queries

Provide props to your React Components based on their Width and/or Height.
MIT License
183 stars 12 forks source link

monitorPosition passthrough #82

Open bradennapier opened 7 years ago

bradennapier commented 7 years ago

Added ability to specify monitorPosition as well.

ctrlplusb commented 7 years ago

Hey @bradennapier

Thanks for taking this on. I am happy with the monitorPosition changes but I am wondering about your motivation for the sizePassThrough prop?

ctrlplusb commented 7 years ago

And... I have just read your first PR notes. Hmmm interesting case. I wonder if this should be considered on react-sizeme.

I would like to take some time to consider this separately. Ideally I think if you are using react-component-queries you shouldn't have the size get passed down to the WrappedComponent anyways. It should only be handled by the responsive functions.

Do you mind removing the concept of size pass through from this PR so we can merge the rest? We can continue the discussion then on the other PR you opened.