Closed hoschi closed 7 years ago
Merging #89 into master will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 98.41% 98.38% -0.03%
==========================================
Files 5 5
Lines 63 62 -1
Branches 17 16 -1
==========================================
- Hits 62 61 -1
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
src/utils/mergeWith.js | 100% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f36630f...341b65e. Read the comment docs.
We just faced the same problem in our project.
What was the original reason for removing props? It seems way too intrusive for a HOC to do that. Could we just get rid of that?
Btw, react-component-queries
is awesome! @ctrlplusb ❤️
Apologies about this. Defo a bug.
Appreciate the PR, I'll look to merge this week if review is good.
Hi @ctrlplusb, did you had a chance to take a look at this? The failure in codecov is pretty weird... I couldn't understand where the coverage was reduced.
Apologies for the tardiness in getting to this. All great. Thank you so much for the help!
@ctrlplusb thanks for looking into my stuff :+1:
Current code remove properties which are "falsy" like
0
.