search

ctrlplusb / react-jobs

Asynchronously resolve data for your components, with support for server side rendering.
MIT License
166 stars 34 forks source link

Added support for React 16 #42

Closed DPr00f closed 6 years ago

DPr00f commented 6 years ago

@ctrlplusb I've been using react-jobs with react-universally and react@16 There's nothing within react-jobs that would prevent it from working with react@16 Can you please do a minor release?

codecov[bot] commented 6 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files           5        5           
  Lines         103      103           
  Branches       31       31           
=======================================
  Hits           97       97           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f99572...c3daca9. Read the comment docs.

ctrlplusb commented 6 years ago

Hey @DPr00f. Apologies for not getting to this yet. Was there a specific reason you decided to close this?

DPr00f commented 6 years ago

No worries @ctrlplusb , The reason is that those changes are in the #43 already. Feel free to reopen it if you want to do this one before #43 or if you don't want to merge #43 at all