ctrlplusb / react-jobs

Asynchronously resolve data for your components, with support for server side rendering.
MIT License
166 stars 34 forks source link

withJob has workingProps state to ignore a old work's late resolve. #46

Closed dehypnosis closed 6 years ago

dehypnosis commented 6 years ago

To solve issue #45 (Need to abort an old work when a new work started).

I made a simple solution.

I'd like you to take a look at it.

codecov[bot] commented 6 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files           5        5           
  Lines         103      103           
  Branches       31       31           
=======================================
  Hits           97       97           
  Misses          6        6
Impacted Files Coverage Δ
src/withJob.js 91.52% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f99572...9063ce3. Read the comment docs.

dehypnosis commented 6 years ago

I forgot to make a new branch for this feature.. I will make new branch for this feature and rewrite pull request