ctrlplusb / react-jobs

Asynchronously resolve data for your components, with support for server side rendering.
MIT License
166 stars 34 forks source link

Remove deprecation warning, bump react-async-bootstrapper version #55

Closed szist closed 6 years ago

szist commented 6 years ago

This should solve deprecation warnings when using react-jobs with the latest react-async-bootstrapper

"react-async-bootstrapper" deprecation notice: please rename your "asyncBootsrap" methods to "bootstrap"
codecov[bot] commented 6 years ago

Codecov Report

Merging #55 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files           5        5           
  Lines         103      103           
  Branches       31       30    -1     
=======================================
  Hits           97       97           
  Misses          6        6
Impacted Files Coverage Δ
src/withJob.js 91.52% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7268262...7159b51. Read the comment docs.

mathportillo commented 6 years ago

I wish this gets released, the deprecation notice creates lots of noise

LeeCheneler commented 6 years ago

Is this going to get merged??

LeeCheneler commented 6 years ago

@ctrlplusb is there other work going on that makes this PR irrelevant or is there a package that has replaced this one? Would love to help get this over the line, trying to sell this stack to stake holders and the constant deprecation logs don't help 😹

If there is a newer stack we should be using than react-async-component, react-jobs and react-async-bootstrapper I'd love to know 😛

ctrlplusb commented 6 years ago

Hey @LeeCheneler

Sorry I haven't given all 3 projects any love of recent and need to do a refresh on them all.

I will try and see to the dependency updates within the next few days.

Regards;

LeeCheneler commented 6 years ago

Ah brilliant 😃

FYI, these packages are totally awesome! Vastly simplify the whole SSR async problem!

ctrlplusb commented 6 years ago

Closing this as I have done it separately. Apologies - I wanted to do a big dep update and some refactoring at the same time.

Thanks for your help and patience! ⭐️