search

ctrlplusb / react-jobs

Asynchronously resolve data for your components, with support for server side rendering.
MIT License
166 stars 34 forks source link

prevent utils.isPromise to crash when passing null #61

Open Platane opened 5 years ago

Platane commented 5 years ago

hello,

Due to typeof null === 'object the isPromise test is crashing when passing null

Here a demo: https://codesandbox.io/s/3vyq17zy35

This PR fix that

codecov[bot] commented 5 years ago

Codecov Report

Merging #61 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files           6        6           
  Lines         114      114           
  Branches       34       34           
=======================================
  Hits          104      104           
  Misses          8        8           
  Partials        2        2
Impacted Files Coverage Δ
src/utils.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53afde8...f5eb416. Read the comment docs.