search

ctrlplusb / react-sizeme

Make your React Components aware of their width and height!
MIT License
1.95k stars 94 forks source link

Support react 17 peer dependency. #201

Closed bcomnes closed 3 years ago

bcomnes commented 4 years ago

Simple change, just increases the semver range of the react peer deps. Everything working good on 17 from what I can tell.

Hypnosphi commented 3 years ago

@ctrlplusb can you please review

bcomnes commented 3 years ago

Any chance for a quick review/merge/release? Would really help downstream issues with the new npm 7 peer dep changes. Thank you!

bcomnes commented 3 years ago

Happy new year! Is there anything I can do to help land this?

Hypnosphi commented 3 years ago

I've published your fork as @hypnosphi/react-sizeme

bcomnes commented 3 years ago

Awesome thank you @Hypnosphi for making this happen.

brodycj commented 3 years ago

Bump with a caveat: updating to react@17 gave me some test failures, needs further investigation.

ctrlplusb commented 3 years ago

I shall publish a version of this soon. 🙏

brodycj commented 3 years ago

Thanks for taking care of the updates !!

On Fri, Feb 26, 2021 at 11:28 AM Sean Matheson notifications@github.com wrote:

I shall publish a version of this soon. 🙏

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ctrlplusb/react-sizeme/pull/201#issuecomment-786750779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL42UD223V3S3S2FKWS7ZDTA7DZRANCNFSM4TLVEFTA .