DllPlugin: the .jsx files are they bundled?

[enten]

File: tools/development/ensureVendorDLLExists.js

I think there is a mistake when the modules list is computed.

Indeed, jsx extension is allowed by the tools/webpack/configFactory.

But, the getJsFilesFromSrcDir function (in ensureVendorDLLExists.js) catch **/*.js files only.

function getJsFilesFromSrcDir(srcPath) {
  return globSync(`${pathResolve(appRootPath, 'src', srcPath)}/**/*.js`);
}

How about the .jsx files? I think they are skipped.

[ctrlplusb]

Good catch. I don't use the .jsx format myself so this is an oversight. :)

[ctrlplusb]

Appreciate the detailed reports!

[ctrlplusb]

Would you be interested in becoming a collaborator on this project and doing a PR to fix this? :)

[enten]

I suggest:

function getJsFilesFromSrcDir(srcPath) {
  return ['js', 'jsx']
    .reduce((acc, ext) =>
      acc.concat(globSync(`${pathResolve(appRootPath, 'src', srcPath)}/**/*.${ext}`), []);
}

So, in buildVendorDLL function, we don't need to check files extension anymore (glob.sync already do the job): - const isJsFile = file => pathExtName(file) === '.js'; - const allJSFiles = [...clientFiles, ...universalFiles].filter(isJsFile); + const allJSFiles = [...clientFiles, ...universalFiles];

Would you be interested in becoming a collaborator on this project and doing a PR to fix this? :)

If I can make real contributions, why not :)

EDIT1: initialize the reducer with an empty array EDIT2: remove useless filtering

[ctrlplusb]

Done! That looks great. I like your style!

[ctrlplusb]

On next branch.