search

ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.69k stars 243 forks source link

CORS security fix #432

Closed diondirza closed 7 years ago

diondirza commented 7 years ago

This PR will solve this #431 issue

ctrlplusb commented 7 years ago

Awesome, thanks again @diondirza

Do you mind rolling back the dependency upgrades? We can do dependency upgrading seperately.

Also, as we use yarn, when upgrading dependencies please make sure to use yarn, passing in the --exact flag.

You can get an interactive upgrade terminal like so:

yarn upgrade-interactive --exact

👍

diondirza commented 7 years ago

No problem, been using that command for every update.

diondirza commented 7 years ago

@ctrlplusb done, please review it again

ctrlplusb commented 7 years ago

Rad, thanks dude!

ctrlplusb commented 7 years ago

You are on a roll!