search

ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Error in IE10 #450

Open haddoq opened 7 years ago

haddoq commented 7 years ago

There seems to be a problem with IE10 both on local machine and on https://react-universally.now.sh/ Shouldn't the site work in IE10 with babel-env "last 2 versions" and polyfill.io? Got these errors in the devtools console:

Error walking your react tree TypeError: Unable to get property 'asyncComponents' of undefined or null reference {

  __symbol:__symbol:react.element0.7163679959125997: undefined,
  __symbol:hasInstance0.71636799591259978: undefined,
  __symbol:isConcatSpreadable0.71636799591259979: undefined,
  __symbol:iterator0.71636799591259971: undefined,
  __symbol:match0.716367995912599710: undefined,
  __symbol:NaN0.71636799591259974: undefined,
  __symbol:NaN0.71636799591259976: undefined,
  __symbol:replace0.716367995912599711: undefined,
  __symbol:search0.716367995912599712: undefined,
  __symbol:species0.71636799591259972: undefined,
  __symbol:split0.716367995912599713: undefined,
  __symbol:toPrimitive0.716367995912599714: undefined,
  __symbol:toStringTag0.71636799591259977: undefined,
  __symbol:undef0.71636799591259973: undefined,
  __symbol:undef0.71636799591259975: undefined,
  __symbol:unscopables0.716367995912599715: undefined,
  description: "Unable to get property 'asyncComponents' of undefined or null reference",
  message: "Unable to get property 'asyncComponents' of undefined or null reference",
  name: "TypeError",
  number: -2146823281,
  stack: "TypeError: Unable to get property 'asyncComponents' of undefined or null reference

at t (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:120829) at Anonymous function (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:216661) at s (https://cdn.polyfill.io/v2/polyfill.min.js?features=default,es6:3:14311) at n.exports (https://cdn.polyfill.io/v2/polyfill.min.js?features=default,es6:3:16834) at r (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:216028) at p (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:216277) at c (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:216486) at Anonymous function (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:216780) at s (https://cdn.polyfill.io/v2/polyfill.min.js?features=default,es6:3:14311) at n.exports (https://cdn.polyfill.io/v2/polyfill.min.js?features=default,es6:3:16834)" }

Uncaught (in promise) TypeError: Unable to get property 'asyncComponents' of undefined or null reference at t (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:120829) at _.constructComponentWithoutOwner (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:138355) at .constructComponent (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:138219) at .mountComponent (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:137406) at mountComponent (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:13407) at .performInitialMount (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:139178) at .mountComponent (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:137982) at mountComponent (https://react-universally.now.sh/client/index-aa82d9f216c877685074.js:1:13407) at _.performInitialMount (https://react-universally.now.sh/client/index-aa82d9

strues commented 7 years ago

Try adding Symbol to the polyfill.io include.

haddoq commented 7 years ago

Symbol is included via the es6 set. I think the problem is that the rendering of the client happens before the polyfill.io is loaded and ready. Maybe we could load the polyfills with a callback that start the render. https://polyfill.io/v2/polyfill.min.js?callback=polyfillsAreLoaded