ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.69k stars 243 forks source link

Does anyone have a fork or feature branch without server bundling? #464

Closed unleashit closed 6 years ago

unleashit commented 7 years ago

I like this repo a lot except for the complexity that's been added around server bundling.. Since almost all of ES6 (and higher) is supported by Node natively I'm not sure why this is needed.

I was just stuck for almost the last hour trying to figure out why relative paths were broken until I realized that JS was being served from build/server and thus __dirname was actually there instead of the source file location. I'm still not sure if I should try to include the json files in question into the server bundle, but I think it's ok.

The other drawbacks are slower build times, more files/cruft, and a more complex webpack configuration that takes longer to figure out.

If anyone has already pulled server bundling out of the project, I'd love to hear about it. If not, I may try to tackle it at some point.