search

ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Is the ReactHotLoader component still necessary? #486

Closed codepunkt closed 6 years ago

codepunkt commented 7 years ago

When importing AppContainer directly from react-hot-loader/lib/AppContainer, this is imported:

if (!module.hot || process.env.NODE_ENV === 'production') {
  module.exports = require('./AppContainer.prod');
} else {
  module.exports = require('./AppContainer.dev');
}

AppContainer.prod is more or less what the prod version of our ReactHotLoader component is. Can the ReactHotLoader component be removed?

ctrlplusb commented 6 years ago

Yep, thanks for this @codepunkt