ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

update to avoid 'Warning: Accessing PropTypes via the main React' #488

Closed andersoo closed 6 years ago

andersoo commented 7 years ago

sorry for my last PR, it was a mistake.

this will eliminate this warning (not a big deal, just annoying when you see it everytime the server refreshes):

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

EDIT: i updated all the packages so they are update with master, babel-cli 6.25.0 is not on the npm list so i tried 6.26.0, style loader and normalize.css are upgraded further than master because, otherwise it gives me warnings

ctrlplusb commented 6 years ago

Hi @andersoo thanks for this. Do you mind rebasing and then I would be happy to merge. ❤️

sergiokopplin commented 6 years ago

@andersoo hey man! I'm not getting that. Are you using the most recent redux branch?