ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Promise undefined for offline build #490

Closed alexanderfrey closed 6 years ago

alexanderfrey commented 7 years ago

Hi there !

First of all thanks for your amazing work. I just ran into a problem with the client offline build (yarn build) that is running fine for most modern browsers but not so for IE 11. It seems that polyfilling is not being run early enough (or run at all) for the offline.html compilation.

S2R:

Does anyone experience similar behavior ?

Any help is very much appreciated.

Best, Alexander

unleashit commented 7 years ago

Haven't done much testing of service workers on my project because I think it'll take significant work to really support. But when I turn them on they're pretty much working as expected (i.e. fine on static pages included in the main bundle, but problems on code split components or with API calls where the user hadn't landed before the connection went down).

Neither IE11 nor Edge currently support Service Workers: http://caniuse.com/#feat=serviceworkers

And I don't think polyfill.io covers it. I just tested in my setup, and while I don't have the issues you have with promises (as long as the polyfill is on), I simply get a white page with "Can't reach this page" if I try to reload while the server is down/off.

ctrlplusb commented 6 years ago

Gonna do some heavy IE testing based on other issues. Will close this for now.