ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Snapshot test failing for `HomeRoute` and `AboutRoute` #503

Open oyeanuj opened 6 years ago

oyeanuj commented 6 years ago

Hey @ctrlplusb, I am seeing snapshot tests failing after your latest commits. I can reproduce it on a fresh install, so not sure if I am missing something.. but wanted to bring it to your notice anyway:

→ yarn test
yarn run v1.1.0
warning ../../package.json: No license field
$ jest
 FAIL  shared/components/DemoApp/AsyncHomeRoute/__tests__/HomeRoute.test.js
  ● <HomeRoute /> › renders

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot 1.

    - Snapshot
    + Received

    @@ -1,8 +1,7 @@
     <div>
       <HelmetWrapper
    -    defer={true}
         encodeSpecialCharacters={true}
       >
         <title>
           Home
         </title>

      at Object.test (shared/components/DemoApp/AsyncHomeRoute/__tests__/HomeRoute.test.js:11:21)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)
      at process._tickCallback (internal/process/next_tick.js:109:7)

 PASS  shared/components/DemoApp/Error404/__tests__/Error404.test.js
 FAIL  shared/components/DemoApp/AsyncAboutRoute/__tests__/AboutRoute.test.js
  ● <AboutRoute /> › renders

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot 1.

    - Snapshot
    + Received

    @@ -4,11 +4,10 @@
           "textAlign": "center",
         }
       }
     >
       <HelmetWrapper
    -    defer={true}
         encodeSpecialCharacters={true}
       >
         <title>
           About
         </title>

      at Object.test (shared/components/DemoApp/AsyncAboutRoute/__tests__/AboutRoute.test.js:11:21)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)
jafri commented 6 years ago

Same issue: npm run prepush -- -u fixes it