ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Colors to chalk #512

Closed oyeanuj closed 6 years ago

oyeanuj commented 6 years ago

Hi folks! I know this has been discussed a couple of times before with the decision to ultimately not make the change. But I ran into some webpack errors with colors and decided to change it in my fork.

Essentially, colors hasn't seen updates for a couple of years, and has an outstanding issue preventing it from always playing well with webpack. As per the rule mentioned by @strues, time to update.

So, figured I'd offer the PR incase there was interest.

ctrlplusb commented 6 years ago

Awesome, thanks for taking this on @oyeanuj

Would you mind pointing it to the next branch instead?

I wanna keep master with bug fixes for now. :)

oyeanuj commented 6 years ago

@ctrlplusb Done! Let me know if it looks good!

strues commented 6 years ago

👍