ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Changing webpack-md5-hash to webpack-chunk-hash #541

Closed newsiberian closed 6 years ago

newsiberian commented 6 years ago

Hi, due to fix webpack 3 deprecation warning about Chunk.modules webpack-md5-hash changed to it fork webpack-chunk-hash;

from webpack-chunk-hash page:

Plugin to replace a standard webpack chunk hashing with custom (md5) one.

Note: It's a clone of webpack-md5-hash plugin, but without sorting provided chunks (unobtrusive), and using native crypto module (performance).

oyeanuj commented 6 years ago

@newsiberian I tested it on my fork and it looks good. The only thing I think it needs is updating the comment here:

https://github.com/newsiberian/react-universally/blob/c2edad0cab689c96e4a911c70cb157f8c197caae/internal/webpack/configFactory.js#L101

Otherwise, LGTM

birkir commented 6 years ago

This should become obsolete in next branch with webpack 4, please let me know if you think webpack hasn't resolved this yet.

newsiberian commented 6 years ago

@birkir, nope, you're right. Closing it