search

ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Use mini-css-extract instead of extract-text-plugin #569

Open diondirza opened 6 years ago

diondirza commented 6 years ago

Using mini-css-extract plugin improve our page load time, since css will be trimmed per view usage, instead of load big chunk unused style in single css file its better to have css loaded on demand, based on page view

unleashit commented 6 years ago

I think this is a great idea as long as it can support having a global css and css modules. I'm assuming if you put an import in a top level component (and don't use css modules in webpack) that would solve the global problem. Will this just work out of the box with import() and react-async-component? How cool.

oyeanuj commented 6 years ago

@diondirza @unleashit how is this working out for you so far? Good to merge or are there known issues?