search

ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Use babel 7 and development property on react-preset #574

Open Aetherall opened 6 years ago

Aetherall commented 6 years ago

Hello ! Thanks for this awesome project !

Just a small PR to use babel 7 :) :tada:

Also, removed 'transform-react-jsx-xxx' plugins, since they are used when using the development property on preset-react

ctrlplusb commented 6 years ago

Awesome, thanks for the contribution! 🤘

oyeanuj commented 6 years ago

@ctrlplusb Is this and the next ready to merge to master?

hguillermo commented 6 years ago

@oyeanuj Waiting for the same! @ctrlplusb Any potential date?

hguillermo commented 6 years ago

I can't wait for the merge. What I remember is @ctrlplusb was waiting for a new version of react-tree-walker. cc @oyeanuj

oyeanuj commented 6 years ago

@Aetherall Do you have an updated version of this PR? And how has Babel 7 been working for you?

Aetherall commented 6 years ago

@oyeanuj No, I do not, I am not using RU anymore, but IMO it should still work. This PR is really just about renaming babel plugins in the configuration.

Babel 7 has been working exactly like Babel 6, You can make this step serenely

oyeanuj commented 5 years ago

@ctrlplusb Is this good to merge in next?