search

ctrlplusb / react-universally

A starter kit for universal react applications.
MIT License
1.7k stars 244 forks source link

Vendor DLL script tag #589

Open mb8z opened 6 years ago

mb8z commented 6 years ago

Hey guys!

I have been using the dll webpack plugin without even noticing it running thanks to your boilerplate. That's awesome! 🎉

Recently I added more packages to the devVendorDLL.include as my builds were getting slower and slower - the app is getting bigger and bigger. My __dev_vendor_dll__.js file is now over 5MB and I've noticed it is not being cached by the browser because of the ?t=${Date.now()} added in the ServerHTML.js file.

My question is - is this a desired behavior? With this in place my browser fetches the file every time I reload the page, and that's a pretty big file for a browser.

oyeanuj commented 5 years ago

@Ancinek What solution did you end up with on this one?

mb8z commented 5 years ago

@oyeanuj I’ve just remove the Date.now method from the script tag. I have not noticed any unwanted behavior with this change :)