search

ctrlpvim / ctrlp.vim

Active fork of kien/ctrlp.vim—Fuzzy file, buffer, mru, tag, etc finder.
ctrlpvim.github.com/ctrlp.vim
Other
5.57k stars 260 forks source link

Unescape paths for GlobPath #579

Closed mattn closed 2 years ago

mattn commented 2 years ago

Closes #138, #572

tacahiroy commented 2 years ago

Confirmed your latest patch fixes issues #138 and #572.

mattn commented 2 years ago

What do you think?

escape part is complex that is given parametes for way to specify escape-pattern. But unescap part does not know the escaped-pattern. So this is harder to work perfectly. However this patch is less wrong. I think.

tacahiroy commented 2 years ago

What do you think?

escape part is complex that is given parametes for way to specify escape-pattern. But unescap part does not know the escaped-pattern. So this is harder to work perfectly. However this patch is less wrong. I think.

Indeed. And I think this fixes very popular problematic cases, so this is enough for now. Thanks for fixing issues which had been listed for a long time.