search

ctron / package-drone-jenkins

A Package Drone Plugin for Jenkins
3 stars 4 forks source link

Plugin should mark job as FAILED if upload fails #1

Closed nfalco79 closed 8 years ago

nfalco79 commented 8 years ago

The plugin should marks the job as failed if upload fails.

Other way add checkbox settings to customise the behaviour if mark job failed when upload fails or not.

By default should be enabled otherwise you never know if artifact was deployed until you are looking in the channel them.

Package Drone Server URL: http://10.0.5.203:8080 ERROR: Failed to upload com.example-1.4.0.v43000018.zip: 401 Unauthorized = Please authenticate Finished: SUCCESS

ctron commented 8 years ago

Different people have different requirements ;-)

But I would say adding a configuration option which allows to mark the build failed in this case would make sense.

nfalco79 commented 8 years ago

Thank for the quicly response.

I propose the same default behaviour of similar plugin as the embedded plugin "Archieve the Artifacts", "Deploy artifact to Artifactory/Maven" plugin and all the "Send build artifact over ...." plugins.

ctron commented 8 years ago

Well I do have a scenario where I don't want the build to fail. So adding a check box sounds like a good idea.

If you can make a pull request I can do it on Monday.

ctron commented 8 years ago

Thanks for the patch! I just release version 0.2.4, which contains your fix. I am not sure though how long it will take until the upload is visible. Last time it was a few days.