search

ctron / package-drone-jenkins

A Package Drone Plugin for Jenkins
3 stars 4 forks source link

Findbugs fails the build #21

Closed ctron closed 7 years ago

ctron commented 7 years ago

I just tried to make the release build and it seems that there is a findbugs step which fails now:

    [INFO] --- findbugs-maven-plugin:3.0.4:check (findbugs) @ package-drone ---
    [INFO] BugInstance size is 6
    [INFO] Error size is 0
    [INFO] Total bugs: 6
    [INFO] Found reliance on default encoding in de.dentrassi.pm.jenkins.util.LoggerListenerWrapper.debug(String): new java.io.PrintWriter(OutputStream) [de.dentrassi.pm.jenkins.util.LoggerListenerWrapper] At LoggerListenerWrapper.java:[line 66] DM_DEFAULT_ENCODING
    [INFO] Found reliance on default encoding in de.dentrassi.pm.jenkins.util.LoggerListenerWrapper.debug(String, Object[]): new java.io.PrintWriter(OutputStream) [de.dentrassi.pm.jenkins.util.LoggerListenerWrapper] At LoggerListenerWrapper.java:[line 77] DM_DEFAULT_ENCODING
    [INFO] Found reliance on default encoding in de.dentrassi.pm.jenkins.util.LoggerListenerWrapper.info(String): new java.io.PrintWriter(OutputStream) [de.dentrassi.pm.jenkins.util.LoggerListenerWrapper] At LoggerListenerWrapper.java:[line 85] DM_DEFAULT_ENCODING
    [INFO] Found reliance on default encoding in de.dentrassi.pm.jenkins.util.LoggerListenerWrapper.info(String, Object[]): new java.io.PrintWriter(OutputStream) [de.dentrassi.pm.jenkins.util.LoggerListenerWrapper] At LoggerListenerWrapper.java:[line 93] DM_DEFAULT_ENCODING
    [INFO] Found reliance on default encoding in de.dentrassi.pm.jenkins.util.LoggerListenerWrapper.warning(String): new java.io.PrintWriter(OutputStream) [de.dentrassi.pm.jenkins.util.LoggerListenerWrapper] At LoggerListenerWrapper.java:[line 101] DM_DEFAULT_ENCODING
    [INFO] Found reliance on default encoding in de.dentrassi.pm.jenkins.util.LoggerListenerWrapper.warning(String, Object[]): new java.io.PrintWriter(OutputStream) [de.dentrassi.pm.jenkins.util.LoggerListenerWrapper] At LoggerListenerWrapper.java:[line 109] DM_DEFAULT_ENCODING
    [INFO]

@nfalco79 Do you have any ideas?

nfalco79 commented 7 years ago

Let me try, I do not undestand why this doesn't fails the build on Travis CI

nfalco79 commented 7 years ago

Ops it was closed automatically because the commit message contains FIX. Anyway I restore the install phase in Travis CI. Originally Travis performs a mvn install followed by a mvn test but here with the cd shell command as before script cutes off the install part.

The idea for LoggerListenerWrapper is create an internal logger based on task listener (that works also on slave). It will be finalised with next POC

ctron commented 7 years ago

So should I give it another try?

chrismathis commented 7 years ago

You could run a mvn verify (instead of install or test) - that should also execute findbugs.

nfalco79 commented 7 years ago

was my first choice but than I change to install to restore the original Travis CI behaviour

https://docs.travis-ci.com/user/languages/java/#Projects-Using-Maven

nfalco79 commented 7 years ago

@ctron yes make other try, should be ok

ctron commented 7 years ago

Looks good.