Add support for credentials plugin for deploy key

ctron / package-drone-jenkins

A Package Drone Plugin for Jenkins

3 stars 4 forks source link

Add support for credentials plugin for deploy key #24

Closed nfalco79 closed 7 years ago

nfalco79 commented 7 years ago

Here should be add the warning message to advise user that persistence is not compatible.

I had try to make this back compatible but the problem is how the build step is build.

coveralls commented 7 years ago

Coverage decreased (-3.7%) to 70.0% when pulling 0c38a1f07b9e93160abc84e5ee3bc790f58508b3 on feature/23 into 19b23dec907983b11fbbd791c51cd7ca6e9f2a48 on master.

coveralls commented 7 years ago

Coverage decreased (-3.3%) to 70.408% when pulling cb9c7add77fbc584402acc55a7a7a967efa38db6 on feature/23 into 19b23dec907983b11fbbd791c51cd7ca6e9f2a48 on master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 73.727% when pulling cdb042347489df8e8c87e77fcf3f173da2122106 on feature/23 into 19b23dec907983b11fbbd791c51cd7ca6e9f2a48 on master.

coveralls commented 7 years ago

Coverage decreased (-0.06%) to 73.631% when pulling f76c1d290ac8cecfb2205c5101f2a64784aaf871 on feature/23 into 19b23dec907983b11fbbd791c51cd7ca6e9f2a48 on master.

coveralls commented 7 years ago

Coverage decreased (-0.06%) to 73.631% when pulling f76c1d290ac8cecfb2205c5101f2a64784aaf871 on feature/23 into 19b23dec907983b11fbbd791c51cd7ca6e9f2a48 on master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 74.239% when pulling f07fe184b355609faa58d6246b70cfd2f902ee85 on feature/23 into 19b23dec907983b11fbbd791c51cd7ca6e9f2a48 on master.

ctron commented 7 years ago

Big thanks for this change!

I would only like to understand what will happen to existing users when they do upgrade this plugin.

nfalco79 commented 7 years ago

When manage jenkins in plugin section they got a red warning message.

Jobs must be re-configured selecting the credentials.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 74.239% when pulling ea3d02a9a9ea98c5f94e0e84680d43324a30d055 on feature/23 into 19b23dec907983b11fbbd791c51cd7ca6e9f2a48 on master.

nfalco79 commented 7 years ago

Add half back compatible mode. This means that it can run old job configuration with deployKey in plain text but if you edit the job configuration for some reason you have to setup deploy key with new credentials.

This allow update the plugin to new one and run without fix each job.

coveralls commented 7 years ago

Coverage increased (+0.6%) to 74.297% when pulling ea3d02a9a9ea98c5f94e0e84680d43324a30d055 on feature/23 into 19b23dec907983b11fbbd791c51cd7ca6e9f2a48 on master.

ctron commented 7 years ago

Just let me know when you want me to release the next version!

Many thanks for your help!

nfalco79 commented 7 years ago

ready for a new release