ctron / package-drone-jenkins

A Package Drone Plugin for Jenkins
3 stars 4 forks source link

Fix #1 Add options to mark the build as failed #4

Closed nfalco79 closed 8 years ago

nfalco79 commented 8 years ago

Add two options to mark the build as failed:

ctron commented 8 years ago

Thanks a lot! That was quick!

Could you do me one favor though, please add yourself to the license header and the pom.xml as a developer. Also for PR #3 .

:+1:

nfalco79 commented 8 years ago

I do not understand what mean "license header". You intend the javadoc @author annotation in the changed files or something different?

ctron commented 8 years ago

Each file has (or at least should have) a header which states:

[1] "Copyright (c) 2015, 2016 IBH SYSTEMS GmbH." -> "Copyright (c) 2015, 2016 IBH SYSTEMS GmbH and others." Unless you created the file, then this would be yourself.

and lists its contributors: [2] just add yourself

[1] https://github.com/nfalco79/package-drone-jenkins/blob/feature/1/package-drone/src/main/java/de/dentrassi/pm/jenkins/DroneRecorder.java#L2

[2] https://github.com/nfalco79/package-drone-jenkins/blob/feature/1/package-drone/src/main/java/de/dentrassi/pm/jenkins/DroneRecorder.java#L8

nfalco79 commented 8 years ago

I hope it's ok now. I make a squash, so a more clearest history.