search

ctron / package-drone-jenkins

A Package Drone Plugin for Jenkins
3 stars 4 forks source link

0.3.x pipeline #9

Closed t794104 closed 7 years ago

t794104 commented 8 years ago

Updated POM and added Pipeline functionality. The following pipeline file worked:

node ('master') { sh ( script: 'wget -q http://obelix/repos/fcd-rhel7/APPdbmon/APPdbmon-1.2.2-999-rhel7-x86_64.rpm' ) packageDrone ( artifacts: '*.rpm', channel: 'test', deployKey: 'a983b48e4c685936bab12a9bcda897a5015d793e8a824c83b81c076fb6c11e70', serverUrl: 'http://repo:8080' ) }

PS: on a node it still gives a error because DefaultHttpClient and Run can't be serialized. This is a bit more work in the 0.3.x release.

ctron commented 8 years ago

This is great work. And I definitely want to follow up on this. Unfortunately this week, and last week, are quite busy for me. I will try to squeeze it in somehow.

ctron commented 7 years ago

Sorry for coming back to you that late!

I hope you still have interest in this PR, the problem is that I have little to no time for this PR.

However if you are interested in taking care of this, I would simply merge this PR and would kindly ask you to follow up on any issues which come along.

Would that work for you?

nfalco79 commented 7 years ago

Annotate @Symbol the descriptor of DroneRecorder should be enough, this also avoid hard dependencies to the pipeline libraries. Have a look to sonar, config-file-provider or nodejs plugins. Generally you implements CPS steps when you are writing a specific pipeline plugin like pipeline-maven-plugin for example to offer an extra effort/support to the maven step.

The updates of parent pom to 2.x and the findbug checks are welcome.

ctron commented 7 years ago

@nfalco79 Could you create an updated PR for this?

nfalco79 commented 7 years ago

@ctron could you commit your formatter in this repo? Becuase it is hard to keep the same kind of code format

ctron commented 7 years ago

Yes, I can do that. But only tomorrow.

nfalco79 commented 7 years ago

This week end I have some time, please commit your eclipse formatter

ctron commented 7 years ago

Sorry for being late. I added the formatter to the local project settings. Alternatively you can take them from here: https://github.com/eclipse/packagedrone/tree/master/setups/eclipse-settings

nfalco79 commented 7 years ago

Partial merge of findsbugs and pom update commits done

nfalco79 commented 7 years ago

pipeline support added by @Symbol annotation