search

ctron / package-drone

An OSGI first software artifact repository – Moved to the Eclipse Foundation
https://github.com/eclipse/packagedrone
Eclipse Public License 1.0
39 stars 13 forks source link

bad generated p2-metadata #102

Closed afischer211 closed 9 years ago

afischer211 commented 9 years ago

I have uploaded an eclipse-feature over the web-interface (drg&drop). In the features-view from the pdrone web-gui the feature is correctly displayed with included plugins, included features and requirements. If I look into the content.xml file (p2-view for the channel), the required plugins are listed as required features?! Here the feature-details from the web-gui: image

And here the fragment of content.xml with bad requirements (feature.group instead of the plugin): image

And at last the content-fragment of feature.xml with defined requirements: `

`

afischer211 commented 9 years ago

The from package-drone auto-generated (and attached as child within repository) file p2metadata.xml has the same errors (requirements for features instead of plugins). Are the any problems with the corresponding aspect "P2 Metadata Generator 1.0.0 – p2.metadata"? What is the decision-base for requirements to bundles or features?

afischer211 commented 9 years ago

After some retries the following new informations: The p2-metadata generation seems to generate for every requirement an entry with the id as feature (.feature.group attached) and as bundle (original id). But the reference to the bundle only occurs, if the bundle with the same id is already located in this channel. If the bundle is not present, then only the reference to the feature is generated. So, if I deploy a feature and later deploy the required bundles, the metadata for the feature are corrupted (bad or missing requirements). Here the (sorted) requirements-entries after uploading some of the required bundles and redeploying the same feature (deleted before): `

` The bundle org.apache.commons.logging with version 1.1.1 is missing, so I get only the feature-requirement, the other needed bundles I have uploaded before redeploy (compare with screenshots above).

ctron commented 9 years ago

I am just checking this.

ctron commented 9 years ago

Now that was a stupid one!

afischer211 commented 9 years ago

Will you build a new yum-package for 0.9.3?

ctron commented 9 years ago

I will .. but I would like to make a test case first.

ctron commented 9 years ago

I uploaded the signed release rpm to the wuala folder.

afischer211 commented 9 years ago

The p2-metadatas for features are correct again with version 0.9.4. I have reload all aspects for the channels for getting correct metadatas again.