search

ctron / package-drone

An OSGI first software artifact repository – Moved to the Eclipse Foundation
https://github.com/eclipse/packagedrone
Eclipse Public License 1.0
39 stars 13 forks source link

different cleanup-configurations #94

Open afischer211 opened 9 years ago

afischer211 commented 9 years ago

Hello, it would be useful to configure different cleanup configurations separately. So I could delete multiple artifacts with same Maven GAV and multiple artifacs with different Maven GAV, but same OSGi-metadata. I could also additionally delete artifacts without OSGi metadata.

afischer211 commented 9 years ago

Another option would be to make grouping informations more configurable. I have .e.g multiple (but limited number of) snaphsot-artifacts and one instance of release-artifact (with version-number without snapshot/qualifier). Today I use a cleanup-configuration based on grouping with Maven-GAV and keeping 3 entries. So I also get 3 instances of the release-artifact. If I can configurure a second cleanup artifact only for release-artifacts, I could solve this problem. Another option could be to group the entries after a regexp of different metainformations (e.g. the part of version-number without the qualifier-part or a concatenation of different informations as one string).

ctron commented 9 years ago

Sorry that this issue did not get as much attention up to know as others.

I would like to have the possibility to use the cleanup aspect multiple times on a channel too. The way it is implemented now was a shortcut. It would cool to have multiple triggers for a channel, which could then trigger operations. A bit like Jenkins/Hudson, but definitely not in the direction of a build server!

Triggers should be extensible, as the rest is, with some common triggers like channel modification, synchronous or asynchronous. Failing the modify operation or not. Executed after every channel modification or after a defined time window. And operations can be attached to triggers, including a specific configuration.

So it would be possible then to choose a trigger "Channel Modified" -> "Cleanup A", "Cleanup B", "Spool out P2".

But this requires a bit more infrastructure in Package Drone an so the Cleanup aspect was simply added as a channel listener. A bit of a hack, but still it works quite well.

But I have to admit that I would rather not extend the current implementation even more since I hope that implementing this trigger system is not too far away.

afischer211 commented 9 years ago

That is ok for me. I will split my P2-repositories to different channels (with different cleanup-settings) and construct a Maven-plugin for automatic choosing the correct channel (URL) for deployment based on different artifact-details (version-number, release or snapshot, groupId,...). So I can wait for the new framework of channel triggers some more days.