search

ctron / rpm-builder

Maven RPM builder plugin
https://ctron.github.io/rpm-builder
Eclipse Public License 2.0
56 stars 32 forks source link

Fixed repodata creation for multiple rpms #13

Closed berndwarmuth closed 7 years ago

berndwarmuth commented 7 years ago

The creation of repodata files was broken when more than one rpm were added to the yum repository. More specifically, the resulting metadata *.xml files have been overwritten in each loop iteration, resulting in having only one package defined in the repodata files. Thus, the yum-repository goal was not usable when intending to add more than one rpm to the repository.

This PR fixes #12 by making sure that the context variable to add rpm packages gets reused in each loop iteration instead of recreated.

ctron commented 7 years ago

Big thanks! Let me know when I should make a new release of the plugin.

berndwarmuth commented 7 years ago

Thanks for responding so fast :) It would be really cool to release a new version right away.

ctron commented 7 years ago

The release is done. It may take a while into it is synced with Maven central.

Many thanks for the PR!

ctron commented 7 years ago

@triggetry Do you have a Twitter handle for mentioning you?

berndwarmuth commented 7 years ago

@ctron sure, https://twitter.com/triggetry

ctron commented 7 years ago

That was easy 😁