search

ctron / rpm-builder

Maven RPM builder plugin
https://ctron.github.io/rpm-builder
Eclipse Public License 2.0
56 stars 32 forks source link

Customize archive name format #24

Closed toomyem closed 6 years ago

toomyem commented 6 years ago

Is it possible to customize format used to create archive's name? Currently it is created with "-arch.rpm" suffix, but there is also convention to use ".arch.rpm" (with dot before arch name).

ctron commented 6 years ago

Woohoo ... that is embarrassing. No you can't. But give me a minute :grin:

yarix commented 6 years ago

the "-arch.rpm" is actually due to this bug - https://github.com/eclipse/packagedrone/issues/123

anyway, i think that it's good that you've added outputFileName (0.10.1) it helped me workaround the issue with: <outputFileName>${project.artifactId}-${project.version}-${rpm.release}.${rpm.architecture}.rpm</outputFileName>

thank you.

toomyem commented 6 years ago

I'd like to note that I also had to manually set package name in addition to outputFileName, otherwise yum wasn't able to install created rpm.

<outputFileName>${rpm.package.name}-${project.version}-1.noarch.rpm</outputFileName>
<packageName>${rpm.package.name}</packageName>
ctron commented 6 years ago

So I guess we can close this issue.

yarix commented 6 years ago

Not sure it's good to close this issue if it's not fixed. The workaround isn't perfect. I suppose that an upgrade to packagedrone, will fix that issue

ctron commented 6 years ago

@yarix You are right. I actually lost track of this being an issue in Package Drone. And there was no released yet which contained eclipse/packagedrone#126 … So I will keep this open and try to find a way to by quicker in making releases of the base RPM library.

ctron commented 6 years ago

This should be fixed in version 1.0.0 which I just released. Please re-open otherwise.