check GET params to limit the records parsed

ctsit / form_render_skip_logic

This REDCap module hides and shows instruments based on the value of a single field on a single form - i.e. a branching logic for instruments.

Other

6 stars 17 forks source link

check GET params to limit the records parsed #53

Closed ChemiKyle closed 5 years ago

ChemiKyle commented 5 years ago

Addresses #49

Makes Record Status Dashboard page loads proportional to number of records viewed instead of entire dataset.

Must be tested with a fairly complicated FRSL configuration to be effective. Should be tested with Linear Data Entry Workflow on as well. I have SQL files that (after a quick sed) can be apply_sql_to_db'd to recreate WARRIOR conditions in a VM (will require fresh VM with edits made to its max_upload sizes to bring in even the metadata-only XML).

These changes do not depend on #51.

marlycormar commented 5 years ago

Hi @ChemiKyle, could you share the configuration you mention above?

marlycormar commented 5 years ago

Hi @ChemiKyle, thanks for sharing the configuration to test this PR.

I have tried to test it many times unsuccessfully. I am stuck in the part of uploading the data. I increased the memory limit and php upload size of the VM (and increased other parameters as well) with no luck. I even tried it in the staging server and I get this error:

which is weird because the file is not as big as the output says. I would like to follow the steps you did to the letter.

marlycormar commented 5 years ago

Load time is proportional to the number of records loaded. Tested it in Chrome and Safari with similar results.