search

ctsit / imagemap

Imagemap REDCap external module
Other
14 stars 27 forks source link

Module now has a limit to images per page #58

Closed ChemiKyle closed 3 years ago

ChemiKyle commented 3 years ago

This affects both Chrome and Firefox, and REDCap 10.5.1 and 10.0.1 on my machine as well as @mbentz-uf. This also occurs on a project I just made on stage_b (PID 21) which is running 10.3.3.

The following error appears in the console:

Uncaught Can't access data until binding complete. bundle.js:234:27834

It appears to be rooted in a timeout.

Strangely, the first 2 image maps from Instrument Example.zip appear, the second does not alter radio buttons, and the rest do not appear at all.

This error does not appear when rolling back to commit 9c8ae5a (though there are many console errors when selecting things) however, commit 6e9499e (which is the head of my PR #54) once again fails.
Something has changed since October 2020 beyond of the scope of this module itself.

123andy commented 3 years ago

I'm asking Jae from my team to look into this as well. This is a priority to fix for a researcher in my team and need to get this out -- I'm okay removing other changes for now -- just the ability to do API endpoints.

ChemiKyle commented 3 years ago

Issue may be rectified by providing some a high enough configTimeout to the initialization of the imageMap object itself https://github.com/jamietre/ImageMapster/issues/96

http://www.outsharked.com/imagemapster/default.aspx?docs.html#configtimeout

https://github.com/ctsit/imagemap/blob/bcba9cf5d306639d147565adf6828a31f1fb3d76/js/imagemap.js#L146-L155

ChemiKyle commented 3 years ago

There appears to be a ~ 2 image limit now. Instrument Example.zip has too many images for now.

123andy commented 3 years ago

I found a work-around for this. I'm making a new pull request.

michael-bentz commented 3 years ago

Addressed by PR #61.