search

ctsit / rcc.billing

Automated, data-driven service billing implemented on REDCap Custodian
https://ctsit.github.io/rcc.billing/
Apache License 2.0
0 stars 3 forks source link

Make pro bono service request records #218

Closed ljwoodley closed 3 months ago

ljwoodley commented 4 months ago

Closes issue #207

ljwoodley commented 4 months ago

I'll create the test for this also.

pbchase commented 4 months ago

Thank you, Laurence. I started working on that yesterday morning but I didn't finish and I really need to be working on other stuff.

From: Laurence James-Woodley @.***> Sent: Tuesday, May 7, 2024 18:08 To: ctsit/rcc.billing Cc: Chase,Philip B; Review requested Subject: Re: [ctsit/rcc.billing] Make pro bono service request records (PR #218)

[External Email]

I'll create the test for this also.

— Reply to this email directly, view it on GitHubhttps://github.com/ctsit/rcc.billing/pull/218#issuecomment-2099396166, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZTOTI6DH4Y3FOVQHB4MVTZBFGF5AVCNFSM6AAAAABG4FI6XCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGM4TMMJWGY. You are receiving this because your review was requested.Message ID: @.***>

ljwoodley commented 4 months ago

Test added.

pbchase commented 4 months ago

My code had multiple issues :-(, but they are now fixed. :-)

Solving the problem required a lot more complexity. I hope the multiple tests of different features demonstrate the function is doing the right thing.