Add fiscal contact details in some places

ctsit / rcc.billing

Automated, data-driven service billing implemented on REDCap Custodian

https://ctsit.github.io/rcc.billing/

Apache License 2.0

0 stars 3 forks source link

Add fiscal contact details in some places #237

Closed pbchase closed 3 months ago

pbchase commented 3 months ago

Sai, I hacked the fiscal contact details into the first batch of invoice line items I sent to Sandra and Laura today. The changes in this PR were necessary to do the job. They are insufficient to satisfy Issue #227 or Issue #225 or the milestone they are part of, but they were required for the Milestone.

Add fiscal_contact_email to get_service_request_line_items.R result.
Transform fiscal_contact_name and fiscal_contact_email.

pbchase commented 3 months ago

The part that surprised me was the change to get_service_request_line_items()

saipavan10-git commented 3 months ago

LGTM. I'll pull these changes to my branch and create a PR with changes related to #227 and #225